Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update HintsLibrary for CRS mgmt functions #17673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (5377ab4) to head (b5554bb).

Files with missing lines Patch % Lines
.../hedera/node/app/hints/impl/HintsLibraryCodec.java 33.33% 4 Missing ⚠️
...rc/main/java/com/hedera/node/app/ServicesMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17673   +/-   ##
=========================================
  Coverage     68.99%   68.99%           
- Complexity    22912    22916    +4     
=========================================
  Files          2639     2639           
  Lines         98946    98960   +14     
  Branches      10261    10261           
=========================================
+ Hits          68263    68273   +10     
- Misses        26792    26796    +4     
  Partials       3891     3891           
Files with missing lines Coverage Δ
...n/java/com/hedera/node/app/hints/HintsService.java 75.00% <ø> (ø)
...m/hedera/node/app/hints/impl/HintsLibraryImpl.java 87.50% <100.00%> (ø)
...app/workflows/standalone/TransactionExecutors.java 91.57% <100.00%> (ø)
...rc/main/java/com/hedera/node/app/ServicesMain.java 28.16% <0.00%> (ø)
.../hedera/node/app/hints/impl/HintsLibraryCodec.java 82.60% <33.33%> (-17.40%) ⬇️

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 70.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5377ab4) 98729 72002 72.93%
Head commit (b5554bb) 98743 (+14) 72012 (+10) 72.93% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17673) 17 12 70.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tinker-michaelj tinker-michaelj added this to the v0.60 milestone Feb 1, 2025
@tinker-michaelj tinker-michaelj self-assigned this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HintsLibrary with latest methods
1 participant