-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added categorizeERCContracts() method to detect and categorize ERC contracts #1048
Merged
quiet-node
merged 3 commits into
main
from
1039-erc-registry-add-ercinterfacematcher-service-class-to-perform-interface-signature-matching-for-erc-contracts
Dec 5, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 16 files ± 0 83 suites +1 12m 27s ⏱️ + 4m 37s Results for commit d429579. ± Comparison against base commit cb20372. This pull request removes 1 and adds 27 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
2 tasks
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…ERC contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
eb9748f
to
d429579
Compare
natanasow
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
tools/erc-repository-indexer/erc-contract-indexer/src/services/byteCodeAnalyzer.ts
Show resolved
Hide resolved
quiet-node
added a commit
that referenced
this pull request
Dec 5, 2024
…ERC contracts (#1048) * chore: installed sevm package Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: added new schemas Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: added categorizeERCContracts() method to detect and categorize ERC contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> feat: ------- added categorizeERCContracts() method to detect and categorize ERC contracts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> feat: added new schemas Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> chore: installed sevm package Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Update ERCRegistrySchemas.ts Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new method,
categorizeERCContracts()
, for the ERC Registry project. The method analyzes a batch of contract bytecodes to detect ERC contracts and categorize them into ERC20 and ERC721. It returns an object containing two arrays: one for ERC20 contracts and another for ERC721 contracts.Related issue(s):
Fixes #1039
Notes for reviewer:
Checklist