Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds example HRC904 contracts + new methods to HTS contract #1125

Merged
merged 22 commits into from
Jan 16, 2025
Merged

feat: adds example HRC904 contracts + new methods to HTS contract #1125

merged 22 commits into from
Jan 16, 2025

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Dec 20, 2024 •
edited by quiet-node
Loading

Description:
This PR adds example contracts for HRC904 #1012 functionality such as cancelAirdrops, claimAirdrops, airdropTokens, rejectTokens as well as adding the new methods to the HederaTokenService.sol contract

Related issue(s):
Closes #1160
Fixes #1135

Notes for reviewer:

Checklist

  • Figure out a way to assert the child transactions (most time consuming so far)
  • Fix some Airdrop contract tests which show wrong balance possibly due to a race condition
  • Polish code and fix assertions to use the right status codes and messages
  • Debug why airdrops fail with more than 5 FT tokens

@simzzz
feat: example contracts + airdrop test coverage
7846701 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: hrc904 proxy test coverage
6f36b90 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz changed the title 1012 proxy coverage feat: Adds test coverage for HRC904Proxy functions Dec 20, 2024
@simzzz simzzz changed the title feat: Adds test coverage for HRC904Proxy functions feat: adds example HRC904 contracts + airdrop test coverage + hrc904Proxy test coverage Dec 20, 2024
simzzz added 2 commits January 6, 2025 14:00
@simzzz
feat: airdropContract test + contract fixes
0e7fabb 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: add tmate for tests
897db78 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
simzzz added 2 commits January 7, 2025 14:25
@simzzz
feat: changed Airdrop tests to get response code of the child transac…
5c5406f 
…tion successfully

Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: unstaging proxy contract tests
0473891 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz changed the title feat: adds example HRC904 contracts + airdrop test coverage + hrc904Proxy test coverage feat: adds example HRC904 contracts + airdrop contract test coverage Jan 7, 2025
@simzzz simzzz marked this pull request as ready for review January 7, 2025 14:01
@quiet-node quiet-node added the enhancement New feature or request label Jan 7, 2025
@quiet-node quiet-node added this to the 0.12.0 milestone Jan 7, 2025
Nana-EC
Nana-EC reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, some tweaks and then let's get this in

Nana-EC
Nana-EC previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

quiet-node
quiet-node reviewed Jan 11, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice process. Non blocking but I have an idea for the PR tho.

Given the urgent priority of pushing the example contracts for Frictionless Airdrop, I suggest repurposing this PR to focus solely on feat: adds example HRC904 contracts.

The test coverage for the AirdropContract can be moved to a separate PR, as I believe it would need additional work on it. This approach is preferable since other contracts, such as CancelAirdrop, ClaimAirdrop, etc., also need test coverage.

Additionally, we would also have these tests running in CI for better visibility as well. And in order to run these tests in CI it would require extra work, including adding a new workflow and updating local-node to use the correct network version.

For now, limiting this PR to the example contracts seems like the best appraoch I believe.

simzzz added a commit to simzzz/hedera-smart-contracts that referenced this pull request Jan 13, 2025
@simzzz
feat: addressed requested changes from hashgraph#1125 + left out Aird…
5d3474e 
…rop contract test coverage for a later PR

Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz dismissed stale reviews from acuarica and Nana-EC via cc959b7 January 13, 2025 10:48
@simzzz
Merge branch 'main' into 1012-proxy-coverage
e50317a 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
simzzz added 5 commits January 13, 2025 13:23
@simzzz
feat: removed console logs and modified gas limit to one test
fac2017 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: renamed constant, added comments to example contracts,
5337201 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: removed unnecessary clarification in a code comment
eea15fc 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: addressed requested changes from hashgraph#1125 + left out Aird…
bb5fddd 
…rop contract test coverage for a later PR

Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: removed AirdropContract.js
087749c 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz force-pushed the 1012-proxy-coverage branch from cc959b7 to 087749c Compare January 13, 2025 11:28
@simzzz
feat: recompiled contracts
95c0013 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: removed unused event from contract
0c57f6f 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz changed the title feat: adds example HRC904 contracts + airdrop contract test coverage feat: adds example HRC904 contracts + new methods to HTS contract Jan 13, 2025
@simzzz
feat: removed test coverage related functions and constants from curr…
d7002d9 
…ent PR

Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz requested a review from quiet-node January 14, 2025 12:16
simzzz added 2 commits January 14, 2025 17:28
@simzzz
feat: clean up tests folder
a089700 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz
feat: recompiled contracts
23d0bd6 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
@simzzz simzzz mentioned this pull request Jan 14, 2025
Closed
quiet-node
quiet-node previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@konstantinabl konstantinabl dismissed their stale review January 15, 2025 11:09

Accidentally approved

konstantinabl
konstantinabl requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@simzzz
feat: renamed prepareAA method
fc1b9a7 
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
quiet-node approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@konstantinabl konstantinabl merged commit e00a81f into hashgraph:main Jan 16, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstantinabl konstantinabl konstantinabl approved these changes

@quiet-node quiet-node quiet-node approved these changes

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0

@stoyanov-st stoyanov-st Awaiting requested review from stoyanov-st

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

@acuarica acuarica Awaiting requested review from acuarica

Assignees

@simzzz simzzz

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
5 participants
@simzzz @acuarica @konstantinabl @Nana-EC @quiet-node