feat: adds tests that verify IHRC904 rejectTokens targeted to an EOA are functional when called by a contract #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
simzzz
requested review from
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
konstantinabl
requested changes
Jan 28, 2025
test/system-contracts/hedera-token-service/hrc-904/TokenRejectContract.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
requested changes
Jan 29, 2025
test/system-contracts/hedera-token-service/hrc-904/TokenRejectContract.js
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/TokenRejectContract.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/TokenRejectContract.js
Outdated
Show resolved
Hide resolved
test/system-contracts/hedera-token-service/hrc-904/TokenRejectContract.js
Show resolved
Hide resolved
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
reviewed
Jan 30, 2025
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
quiet-node
approved these changes
Feb 3, 2025
test/system-contracts/hedera-token-service/hrc-904/TokenRejectContract.js
Show resolved
Hide resolved
konstantinabl
approved these changes
Feb 4, 2025
mp-arianelabs
pushed a commit
to Ariane-Labs/hedera-smart-contracts
that referenced
this pull request
Feb 10, 2025
…are functional when called by a contract (hashgraph#1198) * feat: added test coverage for TokenReject.sol Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * exported magic BigInt as constant Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * requested changes from review Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * changed ONE_HBAR const to use ethers.parseEther Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> --------- Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
mp-arianelabs
pushed a commit
to Ariane-Labs/hedera-smart-contracts
that referenced
this pull request
Feb 10, 2025
…are functional when called by a contract (hashgraph#1198) * feat: added test coverage for TokenReject.sol Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * exported magic BigInt as constant Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * requested changes from review Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> * changed ONE_HBAR const to use ethers.parseEther Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech> --------- Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds tests that verify IHRC904 rejectTokens targeted to an EOA are functional when called by a contract as per the design doc
Related issue(s):
Closes #1190
Notes for reviewer:
Checklist