We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The fix for #83 is incomplete. I use BufferedData.readVarInt() in MerkleDb, it was touched in that fix, but some pieces are still missing.
BufferedData.readVarInt()
In particular, to read bytes BufferedData now takes wrapped buffer offset into consideration:
int tempPos = buffer.position() + buffer.arrayOffset();
However, when it needs to forward buffer position later, the offset is ignored:
buffer.position(tempPos);
Instead, it should be
buffer.position(tempPos - buffer.arrayOffset());
There may be more places broken like this.
The text was updated successfully, but these errors were encountered:
90: BufferedData slices are still broken (#91)
ba9237b
Fixes: #90 Reviewed-by: Ivan Malygin <ivan@swirldslabs.com>, Richard Bair <richard@swirldslabs.com> Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
rbair23
artemananiev
Successfully merging a pull request may close this issue.
The fix for #83 is incomplete. I use
BufferedData.readVarInt()
in MerkleDb, it was touched in that fix, but some pieces are still missing.In particular, to read bytes BufferedData now takes wrapped buffer offset into consideration:
However, when it needs to forward buffer position later, the offset is ignored:
Instead, it should be
There may be more places broken like this.
The text was updated successfully, but these errors were encountered: