Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement IOC #1010

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Ivo-Yankov
Copy link
Contributor

Description

This pull request changes the following:

  • TBD

Related Issues

  • Closes #

@Ivo-Yankov Ivo-Yankov self-assigned this Dec 20, 2024
commit 24269fe
Author: Ivo Yankov <ivo@devlabs.bg>
Date:   Fri Dec 20 11:03:26 2024 +0200

    wip: attempting to fix tests

    Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

commit 7698f16
Author: Ivo Yankov <ivo@devlabs.bg>
Date:   Thu Dec 19 15:41:38 2024 +0200

    chore: format

    Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

commit 507a081
Author: Ivo Yankov <ivo@devlabs.bg>
Date:   Thu Dec 19 14:53:36 2024 +0200

    feat: implement IOC in core classes

    Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

commit c582f12
Author: Ivo Yankov <ivo@devlabs.bg>
Date:   Wed Dec 18 17:32:22 2024 +0200

    wip: refactoring dependencies

    Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon force-pushed the 00822-implement-inversion-of-control-2 branch from 24269fe to dd13b95 Compare December 23, 2024 20:28
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   0s ⏱️ -3s
222 tests  - 6  184 ✅  - 44  0 💤 ±0  38 ❌ +38 
233 runs  ±0  195 ✅  - 38  0 💤 ±0  38 ❌ +38 

For more details on these failures, see this check.

Results for commit c3a9691. ± Comparison against base commit 1b9b7e6.

This pull request removes 9 and adds 3 tests. Note that renamed tests count towards both.
Install function is called with expected parameters ‑ NetworkCommand unit tests Chart Install Function is called correctly Install function is called with expected parameters
Should use local chart directory ‑ NetworkCommand unit tests Chart Install Function is called correctly Should use local chart directory
should throw if and error if nodeAlias is not provided ‑ Certificate Manager should throw if and error if nodeAlias is not provided
should throw if and error if path is not provided ‑ Certificate Manager should throw if and error if path is not provided
should throw if and error if type is not valid ‑ Certificate Manager should throw if and error if type is not valid
waitForPodConditions with first time failure, later success ‑ K8 Unit Tests waitForPodConditions with first time failure, later success
waitForPodConditions with no conditions ‑ K8 Unit Tests waitForPodConditions with no conditions
waitForPodConditions with partial pod data ‑ K8 Unit Tests waitForPodConditions with partial pod data
waitForPods with first time failure, later success ‑ K8 Unit Tests waitForPods with first time failure, later success
"before all" hook for "Install function is called with expected parameters" ‑ NetworkCommand unit tests Chart Install Function is called correctly "before all" hook for "Install function is called with expected parameters"
"before all" hook for "should throw if and error if nodeAlias is not provided" ‑ Certificate Manager "before all" hook for "should throw if and error if nodeAlias is not provided"
"before all" hook for "waitForPods with first time failure, later success" ‑ K8 Unit Tests "before all" hook for "waitForPods with first time failure, later success"

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   0s ⏱️ -12s
222 tests  - 6  184 ✅  - 44  0 💤 ±0  38 ❌ +38 
233 runs  ±0  195 ✅  - 38  0 💤 ±0  38 ❌ +38 

For more details on these failures, see this check.

Results for commit c3a9691. ± Comparison against base commit 1b9b7e6.

This pull request removes 9 and adds 3 tests. Note that renamed tests count towards both.
Install function is called with expected parameters ‑ NetworkCommand unit tests Chart Install Function is called correctly Install function is called with expected parameters
Should use local chart directory ‑ NetworkCommand unit tests Chart Install Function is called correctly Should use local chart directory
should throw if and error if nodeAlias is not provided ‑ Certificate Manager should throw if and error if nodeAlias is not provided
should throw if and error if path is not provided ‑ Certificate Manager should throw if and error if path is not provided
should throw if and error if type is not valid ‑ Certificate Manager should throw if and error if type is not valid
waitForPodConditions with first time failure, later success ‑ K8 Unit Tests waitForPodConditions with first time failure, later success
waitForPodConditions with no conditions ‑ K8 Unit Tests waitForPodConditions with no conditions
waitForPodConditions with partial pod data ‑ K8 Unit Tests waitForPodConditions with partial pod data
waitForPods with first time failure, later success ‑ K8 Unit Tests waitForPods with first time failure, later success
"before all" hook for "Install function is called with expected parameters" ‑ NetworkCommand unit tests Chart Install Function is called correctly "before all" hook for "Install function is called with expected parameters"
"before all" hook for "should throw if and error if nodeAlias is not provided" ‑ Certificate Manager "before all" hook for "should throw if and error if nodeAlias is not provided"
"before all" hook for "waitForPods with first time failure, later success" ‑ K8 Unit Tests "before all" hook for "waitForPods with first time failure, later success"

♻️ This comment has been updated with latest results.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants