Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove v1lease usage outside of kube folder #1622

Merged
merged 7 commits into from
Mar 11, 2025

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • remove v1lease usage outside of kube folder

Related Issues

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…ations

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon self-assigned this Mar 10, 2025
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Unit Test Results - Linux

  1 files  ±0   61 suites  ±0   2s ⏱️ -2s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
245 runs  ±0  245 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2622d3a. ± Comparison against base commit 861e1c2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

Unit Test Results - Windows

  1 files  ±0   61 suites  ±0   3s ⏱️ -1s
236 tests ±0  236 ✅ ±0  0 💤 ±0  0 ❌ ±0 
245 runs  ±0  245 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2622d3a. ± Comparison against base commit 861e1c2.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…n to Lease

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Copy link
Contributor

E2E Test Report

 18 files  ±0  128 suites  ±0   1h 29m 28s ⏱️ -52s
279 tests ±0  279 ✅ ±0  0 💤 ±0  0 ❌ ±0 
297 runs  ±0  297 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2622d3a. ± Comparison against base commit 861e1c2.

Copy link
Contributor

E2E Test Report

 18 files  ±0  128 suites  ±0   1h 29m 28s ⏱️ -52s
279 tests ±0  279 ✅ ±0  0 💤 ±0  0 ❌ ±0 
297 runs  ±0  297 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2622d3a. ± Comparison against base commit 861e1c2.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.14% (target: -1.00%) 69.79%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9d38cfc) 26920 23333 86.68%
Head commit (2622d3a) 27126 (+206) 23473 (+140) 86.53% (-0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1622) 235 164 69.79%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 68.93617% with 73 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (9d38cfc) to head (2622d3a).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/core/lease/interval_lease.ts 45.12% 45 Missing ⚠️
...kube/k8_client/resources/lease/k8_client_leases.ts 62.85% 26 Missing ⚠️
.../kube/k8_client/resources/lease/k8_client_lease.ts 97.95% 1 Missing ⚠️
src/core/lease/interval_lease_renewal.ts 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   85.60%   85.46%   -0.15%     
==========================================
  Files         138      140       +2     
  Lines       26920    27126     +206     
  Branches     2541     2214     -327     
==========================================
+ Hits        23044    23182     +138     
- Misses       3678     3846     +168     
+ Partials      198       98     -100     
Files with missing lines Coverage Δ
src/commands/node/handlers.ts 90.59% <100.00%> (ø)
src/commands/node/tasks.ts 91.26% <100.00%> (-0.28%) ⬇️
src/core/command_handler.ts 68.13% <100.00%> (ø)
src/core/errors.ts 100.00% <100.00%> (ø)
src/core/kube/resources/resource_type.ts 100.00% <100.00%> (ø)
src/core/lease/lease_manager.ts 88.88% <100.00%> (ø)
src/core/lease/listr_lease.ts 80.20% <100.00%> (ø)
.../kube/k8_client/resources/lease/k8_client_lease.ts 97.95% <97.95%> (ø)
src/core/lease/interval_lease_renewal.ts 90.47% <94.11%> (-0.15%) ⬇️
...kube/k8_client/resources/lease/k8_client_leases.ts 77.24% <62.85%> (-7.49%) ⬇️
... and 1 more

... and 42 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeromy-cannon jeromy-cannon marked this pull request as ready for review March 10, 2025 21:08
@jeromy-cannon jeromy-cannon requested a review from a team as a code owner March 10, 2025 21:08
@jeromy-cannon jeromy-cannon added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. labels Mar 10, 2025
@jeromy-cannon jeromy-cannon merged commit f551dc6 into main Mar 11, 2025
41 of 43 checks passed
@jeromy-cannon jeromy-cannon deleted the 01313-remove-v1lease branch March 11, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Manager Approval A pull request that needs review from a manager. PR: Needs Team Approval A pull request that needs review from a team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create custom object in place of V1Lease for use outside of kube folder
2 participants