Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add network command end to end test #177

Closed
wants to merge 54 commits into from

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • add network command end to end test

Related Issues

JeffreyDallas and others added 30 commits March 4, 2024 09:58
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…test

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/cluster.mjs
#	test/e2e/setup-e2e.sh
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
leninmehedy and others added 11 commits March 21, 2024 14:47
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…r setup chart

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners March 22, 2024 14:32
@JeffreyDallas JeffreyDallas changed the base branch from main to add_e2e_test March 22, 2024 14:33
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Mar 22, 2024

Unit Test Results

  1 files  ±0   16 suites  ±0   1m 5s ⏱️ -3s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
134 runs  ±0  134 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6969875. ± Comparison against base commit 48c5b77.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 22, 2024

E2E Test Results

65 tests  +2   65 ✅ +2   6m 8s ⏱️ +13s
 9 suites +1    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6969875. ± Comparison against base commit 48c5b77.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Mar 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.65% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (48c5b77) 2598 1897 73.02%
Head commit (6969875) 2601 (+3) 1916 (+19) 73.66% (+0.65%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#177) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (48c5b77) to head (6969875).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   72.70%   73.44%   +0.73%     
==========================================
  Files          32       32              
  Lines        3111     3111              
  Branches      553      553              
==========================================
+ Hits         2262     2285      +23     
+ Misses        849      826      -23     

see 4 files with indirect coverage changes

Impacted file tree graph

@JeffreyDallas JeffreyDallas changed the base branch from add_e2e_test to main March 22, 2024 21:19
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…network-e2e-test

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	test/e2e/commands/cluster.test.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas deleted the 00138-D-network-e2e-test branch April 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement e2e test for network command
2 participants