Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify jvm env variables explicitly for local profile #405

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

leninmehedy
Copy link
Member

Description

This pull request changes the following:

  • specify jvm env variables explicitly for local profile

Related Issues

@leninmehedy leninmehedy requested a review from a team as a code owner July 1, 2024 07:04
@leninmehedy leninmehedy requested a review from JeffreyDallas July 1, 2024 07:04
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy force-pushed the 00267-specify-jvm-options branch from 4191c65 to 49ac518 Compare July 1, 2024 07:05
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   28s ⏱️ -1s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 60e5b75. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   54s ⏱️ -4s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 60e5b75. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Tests Coverage Report

55 tests   55 ✅  4m 36s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit 49ac518.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Node PFX Kill Add Tests Coverage Report

 1 files   1 suites   7m 52s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit 49ac518.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Node PEM Stop Add Tests Coverage Report

 1 files   1 suites   6m 42s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit 49ac518.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Mirror Node Tests Coverage Report

11 tests   11 ✅  3m 39s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 49ac518.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Node Local Build Tests Coverage Report

8 tests   7 ✅  4m 53s ⏱️
2 suites  0 💤
1 files    1 ❌

For more details on these failures, see this check.

Results for commit 49ac518.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Relay Tests Coverage Report

1 files  1 suites   3m 9s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs  6 ✅ 0 💤 0 ❌

Results for commit 49ac518.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

E2E Test Report

 10 files  ±0   20 suites  ±0   49m 18s ⏱️ +20s
170 tests ±0  170 ✅ ±0  0 💤 ±0  0 ❌ ±0 
173 runs  ±0  173 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 60e5b75. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5fa1b7d) 4070 3295 80.96%
Head commit (60e5b75) 4076 (+6) 3301 (+6) 80.99% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#405) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (5fa1b7d) to head (60e5b75).
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   80.83%   80.84%           
=======================================
  Files          37       37           
  Lines        4885     4887    +2     
  Branches      684      685    +1     
=======================================
+ Hits         3949     3951    +2     
  Misses        936      936           
Files with missing lines Coverage Δ
src/core/profile_manager.mjs 95.85% <100.00%> (+0.03%) ⬆️

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 3db7e08 into main Oct 1, 2024
34 of 35 checks passed
@jeromy-cannon jeromy-cannon deleted the 00267-specify-jvm-options branch October 1, 2024 12:26
swirlds-automation added a commit that referenced this pull request Oct 4, 2024
## [0.31.0](v0.30.1...v0.31.0) (2024-10-04)

### Features

* Add '--mirror-node-version' flag to override default mirror node version ([#616](#616)) ([e4932c4](e4932c4))
* add quiet flag ([#621](#621)) ([b068c8f](b068c8f))
* convert hugo docs workflow calls to use Taskfile task ([#642](#642)) ([ae8d8bb](ae8d8bb))
* ensured user-provided values file takes precedence over solo-generated values ([#615](#615)) ([1b0ffc9](1b0ffc9))
* **logging:** Add the new custom process output class and inject it into the default list renderer options ([#622](#622)) ([efa1783](efa1783))
* separate commands for solo node delete ([#597](#597)) ([b251276](b251276))
* Separate network upgrade and freeze from node update/add/delete command ([#628](#628)) ([9b17937](9b17937))

### Bug Fixes

* Direct calling of node stop and start commands ([#636](#636)) ([7749b04](7749b04))
* **docs:** resolve issues due to npx in taskfile for the custom-network-config example ([038e6df](038e6df))
* jsdoc failed but ci job not failed ([#608](#608)) ([3f838f6](3f838f6))
* specify jvm env variables explicitly for local profile ([#405](#405)) ([3db7e08](3db7e08))
* **tests:** start Kind cluster on demand if not having a kube config errors ([#624](#624)) ([538e40d](538e40d))
* upgrade eslint config away from abandoned plugin ([#643](#643)) ([84d3dc5](84d3dc5))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify resource limits explicitly for local profile
4 participants