Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the commit hash from the readme publish #596

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • use the commit hash from the readme publish

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Sep 18, 2024
@jeromy-cannon jeromy-cannon requested a review from a team as a code owner September 18, 2024 08:19
instamenta
instamenta previously approved these changes Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   26s ⏱️ -1s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 223ccb4. ± Comparison against base commit 3a8fceb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   53s ⏱️ +4s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 223ccb4. ± Comparison against base commit 3a8fceb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 18, 2024

E2E Test Report

 10 files  ±0   20 suites  ±0   47m 49s ⏱️ -39s
168 tests ±0  168 ✅ ±0  0 💤 ±0  0 ❌ ±0 
171 runs  ±0  171 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 223ccb4. ± Comparison against base commit 3a8fceb.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Sep 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a6954d01
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a6954d0) Report Missing Report Missing Report Missing
Head commit (223ccb4) 4073 3305 81.14%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#596) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon merged commit 09d6fb4 into main Sep 18, 2024
27 checks passed
@jeromy-cannon jeromy-cannon deleted the tag-on-diff-commit branch September 18, 2024 10:08
swirlds-automation added a commit that referenced this pull request Sep 18, 2024
## [0.30.1](v0.30.0...v0.30.1) (2024-09-18)

### Bug Fixes

* check if data/upgrade/data/keys exisit ([#587](#587)) ([12bff59](12bff59))
* deploy and tag uses commit-hash from readme ([#601](#601)) ([5d72ffe](5d72ffe))
* more update readme testing ([#599](#599)) ([92d638b](92d638b))
* more update readme testing ([#600](#600)) ([6901f46](6901f46))
* troubleshooting commit-hash ([#602](#602)) ([469f28e](469f28e))
* update readme workflow to use boolean instead of string ([#594](#594)) ([1ec09f7](1ec09f7))
* update readme workflow to use version from semantic-release ([#598](#598)) ([387130f](387130f))
* use the commit hash from the readme publish ([#596](#596)) ([09d6fb4](09d6fb4))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants