Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert config to yaml format #609

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • convert config to yaml format

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners September 18, 2024 17:44
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   26s ⏱️ -1s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 798c9ff. ± Comparison against base commit 5fa1b7d.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Errors should construct correct FullstackTestingError ‑ Errors should construct correct FullstackTestingError
Errors should construct correct SoloError ‑ Errors should construct correct SoloError

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   54s ⏱️ -4s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 798c9ff. ± Comparison against base commit 5fa1b7d.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Errors should construct correct FullstackTestingError ‑ Errors should construct correct FullstackTestingError
Errors should construct correct SoloError ‑ Errors should construct correct SoloError

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 18, 2024

E2E Test Report

 10 files  ±0   20 suites  ±0   49m 26s ⏱️ +28s
170 tests ±0  170 ✅ ±0  0 💤 ±0  0 ❌ ±0 
173 runs  ±0  173 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 798c9ff. ± Comparison against base commit 5fa1b7d.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Sep 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 21.95%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5fa1b7d) 4070 3295 80.96%
Head commit (798c9ff) 4083 (+13) 3307 (+12) 80.99% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#609) 164 36 21.95%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 22.42424% with 128 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (5fa1b7d) to head (798c9ff).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node.mjs 2.85% 34 Missing ⚠️
src/core/k8.mjs 20.00% 24 Missing ⚠️
src/commands/account.mjs 0.00% 11 Missing ⚠️
src/commands/prompts.mjs 0.00% 9 Missing ⚠️
src/core/key_manager.mjs 0.00% 6 Missing ⚠️
src/core/platform_installer.mjs 25.00% 6 Missing ⚠️
src/commands/mirror_node.mjs 0.00% 5 Missing ⚠️
src/core/account_manager.mjs 0.00% 5 Missing ⚠️
src/core/helpers.mjs 68.75% 5 Missing ⚠️
src/core/config_manager.mjs 50.00% 4 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   80.83%   80.85%   +0.01%     
==========================================
  Files          37       37              
  Lines        4885     4895      +10     
  Branches      684      690       +6     
==========================================
+ Hits         3949     3958       +9     
- Misses        936      937       +1     
Files with missing lines Coverage Δ
src/commands/cluster.mjs 58.01% <100.00%> (ø)
src/core/constants.mjs 94.38% <100.00%> (ø)
...rc/core/dependency_managers/dependency_manager.mjs 100.00% <100.00%> (ø)
src/core/errors.mjs 100.00% <ø> (ø)
test/e2e/e2e_node_util.js 86.81% <100.00%> (ø)
test/test_util.js 91.15% <100.00%> (ø)
...dependency_managers/keytool_dependency_manager.mjs 69.13% <0.00%> (ø)
src/core/templates.mjs 72.50% <0.00%> (ø)
src/commands/init.mjs 78.94% <0.00%> (ø)
src/core/package_downloader.mjs 92.70% <50.00%> (ø)
... and 15 more

Impacted file tree graph

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to change the name from ~/.solo/solo.config to ~/.solo/solo.yaml

…config-yaml

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
Copy link
Contributor Author

I would like to change the name from ~/.solo/solo.config to ~/.solo/solo.yaml

Fixed.

@jeromy-cannon jeromy-cannon merged commit 16d40ff into main Sep 30, 2024
33 of 35 checks passed
@jeromy-cannon jeromy-cannon deleted the 00592-D-config-yaml branch September 30, 2024 17:17
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the current solo.config to be stored as YAML instead of JSON
3 participants