Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remote config validation not working #967

Merged
merged 1 commit into from
Dec 10, 2024

fix remote config validation

c657c67
Select commit
Loading
Failed to load commit list.
Merged

fix: remote config validation not working #967

fix remote config validation
c657c67
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 10, 2024 in 0s

82.73% (+0.00%) compared to 0aee1e6

View this Pull Request on Codecov

82.73% (+0.00%) compared to 0aee1e6

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.73%. Comparing base (0aee1e6) to head (c657c67).

Files with missing lines Patch % Lines
src/commands/network.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #967    +/-   ##
========================================
  Coverage   82.73%   82.73%            
========================================
  Files          71       71            
  Lines       19132    19132            
  Branches     1510     1234   -276     
========================================
  Hits        15828    15828            
- Misses       3196     3279    +83     
+ Partials      108       25    -83     
Files with missing lines Coverage Δ
src/core/config/remote/remote_config_validator.ts 93.57% <100.00%> (ø)
src/commands/network.ts 71.14% <0.00%> (ø)

... and 21 files with indirect coverage changes

Impacted file tree graph