Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use gcs for stream file storage #994

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Dec 17, 2024

Description

This pull request changes the following:

  • Refactor create-topic example to also check submitted message from mirror node
  • move create_test_account to individual helper file to shared between solo relay test and gcs test
  • Add test workflow to verify using google storage for stream files upload and download

Related Issues

Test result

https://github.com/hashgraph/solo/actions/runs/12473809302/job/34814887772

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team as code owners December 17, 2024 03:02
@JeffreyDallas JeffreyDallas self-assigned this Dec 17, 2024
@JeffreyDallas JeffreyDallas marked this pull request as draft December 17, 2024 03:02
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   3s ⏱️ ±0s
228 tests ±0  228 ✅ ±0  0 💤 ±0  0 ❌ ±0 
233 runs  ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d6b27e8. ± Comparison against base commit 1b9b7e6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   12s ⏱️ ±0s
228 tests ±0  228 ✅ ±0  0 💤 ±0  0 ❌ ±0 
233 runs  ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d6b27e8. ± Comparison against base commit 1b9b7e6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 18m 41s ⏱️ - 2m 23s
256 tests ±0  256 ✅ ±0  0 💤 ±0  0 ❌ ±0 
259 runs  ±0  259 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ca46661. ± Comparison against base commit a5fab1e.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 21m 49s ⏱️ -1s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d6b27e8. ± Comparison against base commit 1b9b7e6.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Dec 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1b9b7e6) 19689 16848 85.57%
Head commit (d6b27e8) 19717 (+28) 16869 (+21) 85.56% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#994) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (1b9b7e6) to head (d6b27e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   84.58%   84.55%   -0.03%     
==========================================
  Files          74       74              
  Lines       19716    19717       +1     
  Branches     1672     1214     -458     
==========================================
- Hits        16676    16671       -5     
- Misses       2874     3043     +169     
+ Partials      166        3     -163     
Files with missing lines Coverage Δ
src/commands/mirror_node.ts 76.40% <100.00%> (+0.03%) ⬆️

... and 30 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas marked this pull request as ready for review December 19, 2024 16:30
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas marked this pull request as draft December 19, 2024 17:05
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…google-storage

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	version.ts
@JeffreyDallas JeffreyDallas marked this pull request as ready for review December 23, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network]: expose variables to values.yaml for enabling and configuring mirror s3 and gcs backups
1 participant