Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Support/Verify Shared Configuration Region #36

Closed
bflad opened this issue Jun 2, 2020 · 1 comment
Closed

[PROPOSAL] Support/Verify Shared Configuration Region #36

bflad opened this issue Jun 2, 2020 · 1 comment
Labels
enhancement New feature or request tests

Comments

@bflad
Copy link
Contributor

bflad commented Jun 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In the future we may wish to allow region configuration via the AWS shared configuration file (e.g. ~/.aws/config), instead of requiring it via Terraform configuration or environment variables. There may be a few minor adjustments that need to happen to remove direct references to Config.Region, but otherwise the unit testing for GetSession() can theoretically be used to determine this support.

There are caveats to this support though as it can be potentially ambiguous across Terraform executors with varying AWS environment setups, so in the end we may not accept downstream implementations to make the configuration optional.

Potential Library Implementation

// Updates to TestGetSession()

Potential Terraform Backend/Provider Configuration

# Potential future improvements to make the below configurations optional

terraform {
  backend "s3" {
    region = "..."
  }
}

provider "aws" {
  region = ""
}

References

@bflad bflad added enhancement New feature or request tests labels Jun 2, 2020
@gdavison
Copy link
Contributor

Support has been added to v2 of aws-sdk-go-base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
None yet
Development

No branches or pull requests

2 participants