Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http(s) proxy in AWS provider #49

Closed
dkronst opened this issue Sep 1, 2020 · 1 comment
Closed

Add support for http(s) proxy in AWS provider #49

dkronst opened this issue Sep 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dkronst
Copy link
Contributor

dkronst commented Sep 1, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In some setups, an http proxy is used (e.g. for security reasons). It, therefor, may be desirable to have the proxy set as part of the provider's configuration (and not, for example, in the environment - since it will affect the entire process and not just specific configurations).
To support this configuration option in the provider code, support for http proxy has to first be added to the aws sdk go wrapper.

Potential Library Implementation

For example:

	if c.HTTPProxy != "" {
		proxyUrl, err := url.Parse(c.HTTPProxy)
		if err != nil {
			return nil, err
		}

		transport.Proxy = http.ProxyURL(proxyUrl)
	}

Potential Terraform Backend/Provider Configuration

provider "aws" {
   http_proxy = "http://my_proxy:8080"
   region = "cn-northwest-1"
}

References

@dkronst dkronst added the enhancement New feature or request label Sep 1, 2020
@gdavison
Copy link
Contributor

Closed by merging #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants