Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http proxy support as a config option #46

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

dkronst
Copy link
Contributor

@dkronst dkronst commented Jul 26, 2020

Some setups require the use of fine grained proxy settings (and cannot rely on environment variables alone). This PR enables this as a config option.

Cheers!

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #0000 <!--- Pull Requests should have an associated issue or may be closed --->

Please briefly describe the changes proposed in this pull request.

@dkronst dkronst requested a review from a team as a code owner July 26, 2020 06:28
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 26, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this, @dkronst! 🚀

@gdavison gdavison merged commit 1872b23 into hashicorp:main Sep 23, 2021
@dkronst
Copy link
Contributor Author

dkronst commented Sep 23, 2021

that's great! thanks @gdavison!

@gdavison gdavison mentioned this pull request Sep 24, 2021
@gdavison gdavison added this to the v1.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants