Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS_MAX_ATTEMPTS environment variable to configure AWS SDK max attempts #105

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 8, 2022

Use AWS_MAX_ATTEMPTS environment variable to configure AWS SDK max attempts

Closes #101

@gdavison gdavison requested a review from a team as a code owner February 8, 2022 20:33
@gdavison gdavison added this to the v2.0.0 milestone Feb 8, 2022
@YakDriver YakDriver self-assigned this Feb 8, 2022
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

make test
go test -timeout=30s -parallel=4 ./...
ok  	github.com/hashicorp/aws-sdk-go-base/v2	5.923s
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/httpclient	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go v1.42.48
ok  	github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2	0.664s
?   	github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr	0.569s

@gdavison gdavison merged commit 654d4ef into main Feb 8, 2022
@gdavison gdavison deleted the max-attempts-envvar branch February 8, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for max attempts envvar
2 participants