Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-validates Profile name before using it for authentication #128

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

gdavison
Copy link
Contributor

The default AWS SDK authentication flow silently ignores missing profiles, so pre-validate it

Closes #127
Reference hashicorp/terraform-provider-aws#23261
Reference aws/aws-sdk-go-v2#1591

Please briefly describe the changes proposed in this pull request.

@gdavison gdavison requested a review from a team as a code owner February 19, 2022 03:23
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .
ok  	github.com/hashicorp/aws-sdk-go-base/v2	1.695s

@gdavison gdavison merged commit 8a086fb into main Feb 23, 2022
@gdavison gdavison deleted the resolve-profile-name branch February 23, 2022 19:11
@gdavison gdavison changed the title Pre-validates Profile names before using it for authentication Pre-validates Profile name before using it for authentication Feb 23, 2022
gdavison added a commit that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication falls through to IMDS if passed invalid Profile
2 participants