Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sourcing max_attempts from shared config file #278

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

gdavison
Copy link
Contributor

The maximum retry attempts can currently be set directly or by using the AWS_MAX_ATTEMPTS environment variable. Adds support for reading from the shared config file

Closes #114

@gdavison gdavison requested a review from a team as a code owner May 17, 2022 20:50
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .                                   
ok  	github.com/hashicorp/aws-sdk-go-base/v2	1.750s

@gdavison gdavison merged commit 022f1a9 into main Jun 1, 2022
gdavison added a commit that referenced this pull request Jun 1, 2022
@gdavison gdavison deleted the max-attempts-from-shared-config branch June 1, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration: Set max_attempts from shared config file
2 participants