Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more exhaustive GetSession testing and resolve some endpoint customization bugs #32

Merged
merged 10 commits into from
Jun 2, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #2
Reference: hashicorp/terraform-provider-aws#9869
Reference: hashicorp/terraform#25056

Practitioner facing changes:

  • Properly use custom STS endpoint during AssumeRole API calls triggered by Terraform AWS Provider and S3 Backend configurations
  • Properly use custom EC2 metadata endpoint during API calls triggered by fallback credentials lookup

Other changes:

  • Use Go 1.13 wrapped error handling
  • Introduce centralized endpoints.Resolver for custom endpoint handling
  • Introduce mock ECS credentials server
  • Introduce STS AssumeRole valid and invalid API responses

@bflad bflad added the bug Something isn't working label Jun 2, 2020
@bflad bflad added this to the v0.6.0 milestone Jun 2, 2020
@bflad bflad requested a review from a team June 2, 2020 15:24
This was referenced Jun 2, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad merged commit 2cf9105 into master Jun 2, 2020
@bflad bflad deleted the t-GetSession-testing branch June 2, 2020 17:47
bflad added a commit that referenced this pull request Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants