feat: add duplicate json key validator #650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates hashicorp/terraform-provider-aws#33026
Adds a new
ValidateNoDuplicateKeys
function which walks a JSON object checking for duplicate key names. The intention is foraws-sdk-go-base
to contain the core validation logic (ie. provide a JSON string, get back an error) and allow upstream consumers such as the AWS provider to wrap this function and decide whether to return the findings as a diagnostic warning or error.Also creates a new
validation
sub-package and moves the one other existing validation function (ValidateRegion
) into it.