Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RateLimiter is ratelimit.None #977

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Default RateLimiter is ratelimit.None #977

merged 2 commits into from
Mar 19, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 19, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #975.

Changes the default RateLimiter to ratelimit.None.

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/configtesting	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	5.889s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/diag	0.950s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	1.218s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	1.295s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	1.139s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	1.096s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	0.902s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	0.922s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/validation	0.811s

@ewbankkit ewbankkit requested a review from a team as a code owner March 19, 2024 20:35
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit ewbankkit merged commit 71ddd7e into main Mar 19, 2024
12 checks passed
@ewbankkit ewbankkit deleted the f-ratelimit.None branch March 19, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ratelimit.None as default Go SDK v2 API client RateLimiter
2 participants