Update grpc-gateway dependency #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
Jul 30, 2022
johanbrandhorst
changed the title
jefferai
requested changes
Jul 30, 2022
|
I don't think we need to get this in for 0.10.0. The impact of this bug is that an attacker can basically spam the logs of the controller with panic messages. There is no denial of service, as the panic is recovered by the Go HTTP stack. |
johanbrandhorst
force-pushed
the
jbrandhorst-bump-grpc-gateway
branch
from
836e377 to
3809d50
Compare
|
This is ready for review again, we can merge once 0.10.0 is out. |
johanbrandhorst
force-pushed
the
jbrandhorst-bump-grpc-gateway
branch
2 times, most recently
from
162c8a8 to
c620e15
Compare
This fixes an issue which would allow an attacker to trigger a (recovered) panic in the gateway handler.
Testify is not great at handling protobuf types, and was for some reason returning a diff here when in reality there is none. Switch to go-cmp for the comparison to remove the error.
johanbrandhorst
force-pushed
the
jbrandhorst-bump-grpc-gateway
branch
from
c620e15 to
6412aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue which would allow an attacker to trigger a
(recovered) panic in the gateway handler.