Add semgrep rules #5042
Open
Add semgrep rules #5042
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instrument our security scanner with the ability to use custom semgrep rules. This is inspired by the HVS teams use of semgrep.
The event.WithInfoMsg function expects a set of key value tuples, but it can easily be misunderstood to accept string interpolation arguments. This check will error if any string interpolation verbs are used in calls to event.WithInfoMsg
johanbrandhorst
requested review from
jefferai,
mgaffney,
tmessi and
jimlambrt
tmessi
reviewed
Aug 28, 2024
| @@ -0,0 +1,14 @@ | |||
| # Copyright (c) HashiCorp, Inc. | |||
There was a problem hiding this comment.
Can this be placed in a hidden directory, ie .semgrep?
| tuples. | ||
| # Source for Go string interpolation verbs: | ||
| # https://pkg.go.dev/fmt#hdr-Printing. Note that this | ||
| # doesn't detect all uses of string interpolation (e.g. %2f, %#v, %[0]s). |
There was a problem hiding this comment.
Could we expand this to detect these other interpolation cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add semgrep rules
Instrument our security scanner with the ability to use custom semgrep
rules. This is inspired by the HVS teams use of semgrep.
semgrep: add rule to detect string interpolation in WithInfoMsg
The event.WithInfoMsg function expects a set of key value tuples,
but it can easily be misunderstood to accept string interpolation
arguments. This check will error if any string interpolation verbs are
used in calls to event.WithInfoMsg
View this rule in the playground here: https://semgrep.dev/playground/r/YGUpBXB/johan_brandhorst_personal_org.with-info-msg-string-interpolation