Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi-hop.mdx - Added HCP-managed worker multi-hop #5286

Merged
merged 11 commits into from
Dec 6, 2024

Conversation

vanphan24
Copy link
Contributor

Added new section for the use case of multi-hop through HCP-manage worker
Section includes:

  • Use case description
  • Instructions for self-manage config file
  • Example config file
  • Instructions for target filter config

Added new section for the use case of multi-hop through CHP-manage worker
@vanphan24 vanphan24 added the backport/website Backport changes to `stable-website` and the latest release-branch label Nov 25, 2024
@vanphan24 vanphan24 added this to the deferred milestone Nov 25, 2024
@vanphan24 vanphan24 requested a review from a team as a code owner November 25, 2024 20:45
added link to worker tags docs page
changed to active voice.
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition looks amazing, thank you so much! Just a few style suggestions from me 😁.

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
stellarsquall
stellarsquall previously approved these changes Dec 2, 2024
Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this all! Thanks for creating this PR @vanphan24 , this is super helpful info. I added some suggestions for minor rewrites. If those look good to you, I will get this published. But if you have any questions, please let me know. Thank you!!

Co-authored-by: Dan Heath <76443935+Dan-Heath@users.noreply.github.com>
vanphan24 and others added 3 commits December 6, 2024 09:50
Co-authored-by: Dan Heath <76443935+Dan-Heath@users.noreply.github.com>
Co-authored-by: Dan Heath <76443935+Dan-Heath@users.noreply.github.com>
Co-authored-by: Dan Heath <76443935+Dan-Heath@users.noreply.github.com>
@vanphan24
Copy link
Contributor Author

Thank you for the additional suggestions @Dan-Heath! I've committed all of them. Cheers!

@Dan-Heath Dan-Heath self-assigned this Dec 6, 2024
@stellarsquall stellarsquall merged commit c32dcec into main Dec 6, 2024
6 checks passed
@stellarsquall stellarsquall deleted the vanphan24-patch-1---HCP-worker-multi-hop branch December 6, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/website Backport changes to `stable-website` and the latest release-branch docs/concepts website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants