Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tags For CRT #5296

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Update Tags For CRT #5296

merged 1 commit into from
Dec 3, 2024

Conversation

RyanDerr
Copy link
Member

@RyanDerr RyanDerr commented Dec 2, 2024

Overview

Update the build.yml to include the commit sha as part of production tags as part of ICU-15357.

@RyanDerr RyanDerr self-assigned this Dec 2, 2024
@RyanDerr RyanDerr added this to the 0.18.x milestone Dec 2, 2024
@RyanDerr RyanDerr marked this pull request as ready for review December 2, 2024 20:51
@RyanDerr RyanDerr requested a review from a team as a code owner December 2, 2024 20:51
@psekar psekar requested review from tmessi and bosorawis December 2, 2024 21:23
.github/workflows/build.yml Outdated Show resolved Hide resolved
@moduli
Copy link
Collaborator

moduli commented Dec 3, 2024

@tmessi @johanbrandhorst It looks like the CODEOWNERS files has some rules for workflow files requiring github-secure-boundary approval, but it looks like that's just a group for the service account? Do we still need that rule? Releng used to be on that rule, too, but it was removed last year.

@RyanDerr
Copy link
Member Author

RyanDerr commented Dec 3, 2024

@tmessi @johanbrandhorst It looks like the CODEOWNERS files has some rules for workflow files requiring github-secure-boundary approval, but it looks like that's just a group for the service account? Do we still need that rule? Releng used to be on that rule, too, but it was removed last year.

Yeah not sure if this rule makes much sense as it exists currently, and will prevent any merges unless the service account approves workflow PRs.

@johanbrandhorst
Copy link
Collaborator

Yeah, looks like we should remove that group from the CODEOWNERs. I opened #5299 but ran into another error, I will reach out to releng.

@johanbrandhorst
Copy link
Collaborator

I will merge #5299 once it is ready, you may need to rebase to have this PR re-evaluate the CODEOWNERS logic

@RyanDerr RyanDerr requested a review from a team as a code owner December 3, 2024 18:03
@RyanDerr RyanDerr merged commit dc51dfb into main Dec 3, 2024
43 of 44 checks passed
@RyanDerr RyanDerr deleted the ryan/ICU-15359 branch December 3, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants