Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Update test to mitigate timing flake #5347

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Dec 10, 2024

This PR attempts to address a flaky failure on an e2e test

 === RUN   TestCliTcpTargetWorkerConnectTarget
    scope.go:85: Created Org Id: o_ZxSfdYzY8A
    scope.go:127: Created Project Id: p_b0mudNwKQ2
    target_tcp_worker_connect_ssh_test.go:77: Created Vault Credential
    target_tcp_worker_connect_ssh_test.go:97: Created Vault Cred Store Token
    credential.go:99: Created Credential Store: csvlt_ocCer9Zv2D
    credential.go:166: Created Credential Library: clvlt_RT0eBgJjeq
    target.go:127: Created Target: ttcp_njQTKJneDC
    target_tcp_worker_connect_ssh_test.go:156: Successfully connected to target
    target_tcp_worker_connect_ssh_test.go:180: Successfully failed to connect to target with wrong worker filter
    target_tcp_worker_connect_ssh_test.go:208: Adding API tag to worker...
    target_tcp_worker_connect_ssh_test.go:250: Successfully connected to target with new filter
    target_tcp_worker_connect_ssh_test.go:284: Successfully failed to connect to target with wrong filter
    target_tcp_worker_connect_ssh_test.go:287: Changing API tag on worker...
    target_tcp_worker_connect_ssh_test.go:307: 
        	Error Trace:	/src/boundary/testing/internal/e2e/tests/base_with_worker/target_tcp_worker_connect_ssh_test.go:307
        	Error:      	Received unexpected error:
        	            	exit status 255
        	Test:       	TestCliTcpTargetWorkerConnectTarget
        	Messages:   	kex_exchange_identification: read: Connection reset by peer
        	            	Connection reset by 127.0.0.1 port 33913

It looks like we observed one instance where this test failed to connect to a target after changing and API tag on a worker. I have only seen this fail once, which seems to indicate it's some timing thing. For now, this PR adds some retries when connecting to the target after changing worker tag properties.

https://hashicorp.atlassian.net/browse/ICU-15923

@moduli moduli added the pr/no-milestone Ignores the Milestone Check label Dec 10, 2024
Observed one instance of a test failure when the test failed to connect to the target after changing an API tag on the worker.
@moduli moduli force-pushed the moduli-flake-worker-test branch from dd1d107 to 08c245c Compare December 10, 2024 21:38
@moduli moduli marked this pull request as ready for review December 10, 2024 21:38
@moduli moduli requested a review from a team as a code owner December 10, 2024 21:38
@moduli moduli merged commit 8d7a9d7 into main Dec 11, 2024
60 of 62 checks passed
@moduli moduli deleted the moduli-flake-worker-test branch December 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-milestone Ignores the Milestone Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants