Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics and topology endpoints to work nicely together #39

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Update metrics and topology endpoints to work nicely together #39

merged 3 commits into from
Oct 8, 2020

Conversation

banks
Copy link
Member

@banks banks commented Oct 7, 2020

No description provided.

@banks banks requested review from johncowen and kaxcode October 7, 2020 16:18
@banks banks closed this Oct 7, 2020
@banks
Copy link
Member Author

banks commented Oct 7, 2020

Wrong PR closed

@banks banks reopened this Oct 7, 2020
@banks banks mentioned this pull request Oct 8, 2020
Merged
9 tasks
johncowen
johncowen approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @banks , did you notice theres a conflict that needs fixing up here - probably since you PRed this? Other than that I'm sure this is good to go!

@banks
Copy link
Member Author

banks commented Oct 8, 2020

@johncowen yeah I need to look at that - as far as I can tell the endpoint has changed so the intentions moved up to the top level now so I need to rebase and sort that out. @kaxcode FYI. I'll check with freddy that this is right before we merge though.

@banks
Copy link
Member Author

banks commented Oct 8, 2020

Heh the conflict was legit - Kenia added the right thing for intentions and I added the wrong thing. Fixed now!

@banks banks merged commit 946d748 into master Oct 8, 2020
@banks banks deleted the ui-metrics branch October 8, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

@kaxcode kaxcode Awaiting requested review from kaxcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banks @johncowen