Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

conformance: specify consul-k8s-control-plane:latest #196

Merged
merged 1 commit into from
May 23, 2022

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented May 17, 2022

Changes proposed in this PR:

Specify consul-k8s-control-plane:latest image to support installing from Consul Helm chart main branch.

How I've tested this PR:

Running conformance tests, which have been failing in the setup steps (consul-controller and conect-inject-controller pods never become healthy) with Parsing flagset: flag provided but not defined: -consul-api-timeout due to changes in the main branch of the Consul Helm chart but imageK8s defaulting to 0.43.0 still.

How I expect reviewers to test this PR:

Confirm that conformance tests are able to deploy Consul from the Helm chart successfully, and reach expected failures in ReferencePolicy conformance test suite.

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@mikemorris mikemorris added the pr/no-changelog Skip the CI check that requires a changelog entry label May 17, 2022
@mikemorris mikemorris requested a review from a team May 17, 2022 16:12
@nathancoleman
Copy link
Member

Noting that conformance tests make it through the consul install now and fail in the expected manner. Those failing tests will be addressed by a different PR in the future.

@mikemorris mikemorris merged commit 648b2b6 into main May 23, 2022
@mikemorris mikemorris deleted the conformance/imageK8s-latest branch May 23, 2022 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/no-changelog Skip the CI check that requires a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants