Send the Namespace/Partition as gRPC metadata headers in the request to the Consul DNS service. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
… to the Consul DNS service.
…ervice This can be used to enable authenticated DNS and prevent needing to set the default token on the servers.
Comment on lines
+57
to
+63
| // store the final resolved service for others to use. | ||
| cdp.resolvedProxyConfig = ProxyConfig{ | ||
| NodeName: rsp.NodeName, | ||
| ProxyID: cdp.cfg.Proxy.ProxyID, | ||
| Namespace: rsp.Namespace, | ||
| Partition: rsp.Partition, | ||
| } |
There was a problem hiding this comment.
Would you expect that the node, namespace + partition would sometimes differ between rsp and cdp.cfg.Proxy? I ask because I was curious why we can't use cfg.cfg.Proxy directly vs. hanging an additional ProxyConfig on the struct
There was a problem hiding this comment.
Matt might know differently, but I assumed it was that the serviceaccount/Token used to make the bootstrapping could imply a namespace/partition that wasn't specified using the config flags.
nathancoleman
approved these changes
Apr 2, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By passing along the tenant of the service being proxied we can more intelligently select the correct partition/namespace to use as defaults for DNS.
This also passes along the Consul ACL token as the x-consul-token grpc metadata. Eventually Consul should be able to use this token instead of the servers default token for authorizing access.
TODO