Backport of Add emit_tags_as_labels setting to envoy metrics service cfg into release/1.2.x #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #184 to be assessed for backporting due to the inclusion of the label backport/1.2.
The below text is copied from the body of the original PR.
This syncs the change from consul for the same: hashicorp/consul#17888
We need this to get envoy service metrics tagged with source and destination service meta. Without it, we get metrics from Envoy that do not have the upstream service name, partition, etc (it's just the FQDN). Eg:
I made this by:
make copy-bootstrap-config
sync'ing changespkg/consuldp/testdata/TestBootstrapConfig/hcp-metrics.golden
that I guess isn't sync'edTesting & Reproduction steps
I made this change directly to
consul-dataplane
, deployed it to a personal Docker Hub repo, and ranconsul-k8s install
with it:Checked Prometheus and we're getting all the labels:
Links
Envoy docs: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/metrics_service.proto
Overview of commits