Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FIPS version delimiter #203

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix FIPS version delimiter #203

merged 1 commit into from
Jul 18, 2023

Conversation

skpratt
Copy link
Contributor

@skpratt skpratt commented Jul 12, 2023

Backport of #191

@skpratt skpratt added backport/1.2 pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog labels Jul 12, 2023
@skpratt skpratt marked this pull request as ready for review July 12, 2023 20:09
@skpratt skpratt requested a review from a team July 12, 2023 20:09
@skpratt skpratt requested a review from a team as a code owner July 12, 2023 20:09
@skpratt skpratt requested review from marianoasselborn, jeanneryan and curtbushko and removed request for a team July 12, 2023 20:09
curtbushko
curtbushko approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skpratt skpratt merged commit ef6b3f2 into main Jul 18, 2023
34 of 36 checks passed
@skpratt skpratt deleted the skpratt/fips-version-delimiter branch July 18, 2023 16:33
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jul 18, 2023
Merged
hc-github-team-consul-core added a commit that referenced this pull request Jul 19, 2023
@hc-github-team-consul-core @skpratt
Backport of Fix FIPS version delimiter into release/1.2.x (#211)
a5f6414 
## Backport

This PR is auto-generated from #203 to be assessed for backporting due
to the inclusion of the label backport/1.2.



The below text is copied from the body of the original PR.

---

Backport of #191

---

<details>
<summary> Overview of commits </summary>

  - b9bac06 

</details>

Co-authored-by: skpratt <sarah.pratt@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@marianoasselborn marianoasselborn Awaiting requested review from marianoasselborn

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

Assignees
No one assigned
Labels
pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skpratt @curtbushko