Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-4904] security: update Envoy to 1.26.4 #235

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Aug 11, 2023

Also update Go to 1.20.7 in the Dockerfile. It was updated in CI as part of #227.

1.1.x PR: #236
1.0.x PR: #237

@zalimeni zalimeni requested a review from a team as a code owner August 11, 2023 14:04
@zalimeni zalimeni changed the title security: update Envoy to 1.26.4 [NET-4904] security: update Envoy to 1.26.4 Aug 11, 2023
@zalimeni zalimeni requested review from david-yu and skpratt August 11, 2023 14:09
@zalimeni
Copy link
Member Author

@skpratt it looks like we only have 1.26.2 published for the hashicorp/envoy-fips image. Is that expected r/n? I see

If the FIPS patch release from Hashicorp is not available, reach out to the ZTS team.

in your release guide updates so maybe something you anticipated 😄

ERROR: failed to solve: hashicorp/envoy-fips:v1.26.4: docker.io/hashicorp/envoy-fips:v1.26.4: not found
Error: Process completed with exit code 1.

@skpratt
Copy link
Collaborator

skpratt commented Aug 11, 2023

@skpratt it looks like we only have 1.26.2 published for the hashicorp/envoy-fips image. Is that expected r/n? I see

If the FIPS patch release from Hashicorp is not available, reach out to the ZTS team.

in your release guide updates so maybe something you anticipated 😄

ERROR: failed to solve: hashicorp/envoy-fips:v1.26.4: docker.io/hashicorp/envoy-fips:v1.26.4: not found
Error: Process completed with exit code 1.

Yeah, we can either merge this without the FIPS version bump (and I can follow up after envoy-fips:1.26.4 is out - estimating EOD). Or we can wait until envoy-fips:1.26.4 is out.

I'll approve and let you decide.

Copy link
Collaborator

@skpratt skpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to either wait for FIPS image or to remove FIPS image update (which I am happy to do separately)

@zalimeni
Copy link
Member Author

zalimeni commented Aug 11, 2023

Thanks @skpratt ! Sounds like that will probably be available soon, so I'm happy to leave the PR open. Feel free to re-run tests and merge when you're ready.

Edit: going to go ahead and merge while we wait for CI to be sorted out for FIPS, Sarah will follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants