Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding consul-dataplane to VBA (version bump automation) #296

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sarahethompson
Copy link
Contributor

@sarahethompson sarahethompson commented Oct 11, 2023

As per - https://hashicorp.atlassian.net/wiki/spaces/RELENG/pages/2484306717/How+To+Onboard+Version+Bump+Automation

  • new VERSION file and mechanics to get and set the version at build time
  • new bump-version event in ci.hcl that will bump the minor version on the release branch post release
  • new workflow (create-release-branch.yml) that can be manually triggered to create a new release branch from main (and bump the major version on main)

@sarahethompson sarahethompson added the pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog label Oct 11, 2023
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sarah!

It looks good. I have some questions below but I will not block you on them (especially with our time difference)

version/VERSION Outdated
@@ -0,0 +1 @@
1.1.6-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I think this should be 1.3.0-dev ?

organization = "hashicorp"
repository = "crt-workflows-common"
workflow = "bump-version"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do we need the notification here also or does that automatically happen?

   notification {
     on = "fail"
   }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, notifications will be sent on failure without this block. If you'd like to get notifications on success also, you can add:

   notification {
     on = "always"
   }

@sarahethompson sarahethompson marked this pull request as ready for review October 13, 2023 08:56
@sarahethompson sarahethompson requested a review from a team October 13, 2023 08:56
@sarahethompson sarahethompson requested a review from a team as a code owner October 13, 2023 08:56
@sarahethompson sarahethompson requested review from dekimsey and claire-labry and removed request for a team October 13, 2023 08:56
@sarahethompson
Copy link
Contributor Author

@curtbushko I've moved this out of draft. I'll let you merge it in when you're ready!

Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @sarahethompson, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants