-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding consul-dataplane to VBA (version bump automation) #296
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sarah!
It looks good. I have some questions below but I will not block you on them (especially with our time difference)
version/VERSION
Outdated
@@ -0,0 +1 @@ | |||
1.1.6-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I think this should be 1.3.0-dev
?
organization = "hashicorp" | ||
repository = "crt-workflows-common" | ||
workflow = "bump-version" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Do we need the notification here also or does that automatically happen?
notification {
on = "fail"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, notifications will be sent on failure without this block. If you'd like to get notifications on success also, you can add:
notification {
on = "always"
}
@curtbushko I've moved this out of draft. I'll let you merge it in when you're ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @sarahethompson, LGTM!
As per - https://hashicorp.atlassian.net/wiki/spaces/RELENG/pages/2484306717/How+To+Onboard+Version+Bump+Automation
VERSION
file and mechanics to get and set the version at build timebump-version
event in ci.hcl that will bump the minor version on the release branch post releasecreate-release-branch.yml
) that can be manually triggered to create a new release branch from main (and bump the major version on main)