-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): always publish full and minor version tags for dev images #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
requested review from
curtbushko,
zalimeni,
a team,
shore and
jeanneryan
and removed request for
a team
October 18, 2023 14:55
I expect the backports to fail but at least they will be a starting point. |
DanStough
added
the
pr/no-changelog
This PR does not introduce a user-facing change that should be reflected in the changelog
label
Oct 18, 2023
DanStough
force-pushed
the
dans/fix-docker-dev-tag
branch
from
October 18, 2023 15:00
1c07739
to
0c340e1
Compare
zalimeni
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!!
curtbushko
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DanStough
force-pushed
the
dans/fix-docker-dev-tag
branch
from
October 18, 2023 16:42
0c340e1
to
52c14b7
Compare
DanStough
force-pushed
the
dans/fix-docker-dev-tag
branch
from
October 18, 2023 16:44
52c14b7
to
d51f752
Compare
Backport assistant died. . Going in manually. |
This was referenced Oct 18, 2023
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.1
Changes are backported to 1.1
pr/no-changelog
This PR does not introduce a user-facing change that should be reflected in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always publishing full and minor-only tag versions. This accomplishes two goals:
.x
, always publish a minor-only tag so that tests use the latest version (e.g.1.4-dev
).0
, always publish the full version so we can fix this for testing purposes (e.g.1.3.0
)