Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skaffold build experiment #341

Merged
merged 2 commits into from
Nov 13, 2023
Merged

chore: skaffold build experiment #341

merged 2 commits into from
Nov 13, 2023

Conversation

DanStough
Copy link
Contributor

Changes proposed in this PR:

  • Adds a new make target and Dockerfile meant for dev builds or skaffold

How I've tested this PR:
See this repo for usage

How I expect reviewers to test this PR: 👀

@DanStough DanStough added the pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog label Nov 7, 2023
@DanStough DanStough requested a review from a team as a code owner November 7, 2023 21:05
@zalimeni zalimeni mentioned this pull request Nov 7, 2023
Merged
2 tasks
@DanStough DanStough merged commit dc1d3a2 into main Nov 13, 2023
33 checks passed
@DanStough DanStough deleted the dans/skaffold-demo branch November 13, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

Assignees
No one assigned
Labels
pr/no-changelog This PR does not introduce a user-facing change that should be reflected in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanStough @zalimeni