Add telemetry-prom-merge-port flag for merged metrics #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtbushko
changed the title
2 tasks
curtbushko
added
the
pr/no-changelog
curtbushko
force-pushed
the
curtbushko/agentless-metrics-merging
branch
from
8f3883f to
c6fc569
Compare
pglass
reviewed
Oct 19, 2022
3 tasks
pglass
approved these changes
Oct 19, 2022
ishustava
reviewed
Oct 19, 2022
| @@ -54,6 +54,7 @@ func TestMetricsServerClosed(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestMetricsServerEnabled(t *testing.T) { | |||
| mergedMetricsBackendBindAddr := mergedMetricsBackendBindHost + defaultMergedMetricsBackendBindPort | |||
There was a problem hiding this comment.
Should we add tests that the metrics backend port can be overridden?
curtbushko
requested review from
ishustava,
a team,
samsalisbury and
mdeggies
and removed request for
a team
curtbushko
force-pushed
the
curtbushko/agentless-metrics-merging
branch
from
9f26c3b to
bd10094
Compare
Add telemetry flags for merge metrics
curtbushko
force-pushed
the
curtbushko/agentless-metrics-merging
branch
from
bd10094 to
c720af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to consul-dataplane named
telemetry-prom-merge-portwith a default value of20100. This is in order to support merged metrics with consul-k8s. The PR is paired with the consul-k8s PR Merged metrics with consul-dataplane and this PR should be merged before consul-k8s one.I have mainly tested the merged metrics through the consul-k8s acceptance tests and they are passing. The acceptance tests test: