-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exporting of Envoy metrics to HCP for linked clusters #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjti
force-pushed
the
feat/hcp-metrics
branch
4 times, most recently
from
December 20, 2023 21:08
132d863
to
02f8e13
Compare
jjti
commented
Jan 19, 2024
jjti
commented
Jan 23, 2024
jjti
force-pushed
the
feat/hcp-metrics
branch
from
January 26, 2024 16:34
75ff9d2
to
e9781f2
Compare
jjti
changed the title
Support pushing of Envoy metrics to HCP
Add pushing of Envoy metrics to HCP
Jan 26, 2024
johnbuonassisi
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work in here.
nickethier
approved these changes
Jan 31, 2024
jjti
force-pushed
the
feat/hcp-metrics
branch
from
February 1, 2024 15:28
a38b851
to
559813e
Compare
jjti
commented
Feb 1, 2024
jjti
changed the title
Add pushing of Envoy metrics to HCP
Add exporting of Envoy metrics to HCP for linked clusters
Feb 1, 2024
david-yu
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved we'd like to get this into 1.18 GA
jjti
commented
Feb 5, 2024
jjti
commented
Feb 5, 2024
jjti
commented
Feb 8, 2024
loshz
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Bump consul/proto-public and create mocks * Revert some dep changes * Add changelog * Init metrics pushing from consul-dataplane * Add node.id label * Remove unused field * Rename worker vars to exporter * Return a *state in modState * Bump dependency * Remove pointer to exporter * Add mocks in internal/mocks * Fix test * Restore directive * Revert directive * Rename metrics > scraper, remove unused changelog * Fix WatchList for new consul api * Infer auth endpoint if not in state * debug: expose pprof/runtime metrics * Handle snapshot end more gracefully * Fix x-channel header * Fix path registration * Try w/o setting handlers * Use a larger example stats file in envoy_admin_stats_prometheus * Bump proto-public * Remove pprof --------- Co-authored-by: Dan Bond <danbond@protonmail.com> (cherry picked from commit 3bf86d3)
loshz
pushed a commit
that referenced
this pull request
Feb 12, 2024
… into release/1.4.x (#422) Add exporting of Envoy metrics to HCP for linked clusters (#370) * Bump consul/proto-public and create mocks * Revert some dep changes * Add changelog * Init metrics pushing from consul-dataplane * Add node.id label * Remove unused field * Rename worker vars to exporter * Return a *state in modState * Bump dependency * Remove pointer to exporter * Add mocks in internal/mocks * Fix test * Restore directive * Revert directive * Rename metrics > scraper, remove unused changelog * Fix WatchList for new consul api * Infer auth endpoint if not in state * debug: expose pprof/runtime metrics * Handle snapshot end more gracefully * Fix x-channel header * Fix path registration * Try w/o setting handlers * Use a larger example stats file in envoy_admin_stats_prometheus * Bump proto-public * Remove pprof --------- Co-authored-by: Dan Bond <danbond@protonmail.com> (cherry picked from commit 3bf86d3) Co-authored-by: Joshua Timmons <joshua.timmons1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This builds off the work of the Consul PR: hashicorp/consul#20257
We want to let users send Envoy metrics to HCP for use in service-level dashboards and coming service topology map features. We also want to support that without requiring that users deploy a dedicated Consul Telemetry Collector.
The behavior added to Consul Dataplane in this PR is:
More details are available in the RFC: https://docs.google.com/document/d/1gh3_zUtdIDeDPIH7z3d0-kkx1scB2oZLi7yuYg88PK8
Testing
Unit/integration Testing
E2E Testing with HCP
To test this with real values I:
E2E Testing with HCP and a Proxy Server
TelemetryState
has an HTTP proxy for use in environments where egress to the internet (ie HCP) is restricted to a single point of egress. This is similar to the Datadog agent's proxy settings.To test pushing of metrics through a proxy, I set up Nginx locally as a forward proxy:
And confirmed that metrics were pushed thru it to CTGW (both in logs in metrics in Grafana):