-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-2420] security: add security scans on protected branches #433
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
name: Security Scan | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
- release/** | ||
pull_request: | ||
branches: | ||
- main | ||
- release/** | ||
|
||
# cancel existing runs of the same workflow on the same ref | ||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
get-go-version: | ||
uses: ./.github/workflows/reusable-get-go-version.yml | ||
|
||
scan: | ||
needs: | ||
- get-go-version | ||
runs-on: ubuntu-latest | ||
# The first check ensures this doesn't run on community-contributed PRs, who | ||
# won't have the permissions to run this job. | ||
if: ${{ (github.repository != 'hashicorp/consul-dataplane' || (github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name)) | ||
&& (github.actor != 'dependabot[bot]') && (github.actor != 'hc-github-team-consul-core') }} | ||
|
||
steps: | ||
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 | ||
|
||
- name: Set up Go | ||
uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 # v4.0.1 | ||
with: | ||
go-version: ${{ needs.get-go-version.outputs.go-version }} | ||
|
||
- name: Clone Security Scanner repo | ||
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 | ||
with: | ||
repository: hashicorp/security-scanner | ||
#TODO: replace w/ HASHIBOT_PRODSEC_GITHUB_TOKEN once provisioned | ||
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }} | ||
path: security-scanner | ||
ref: main | ||
|
||
- name: Scan | ||
id: scan | ||
uses: ./security-scanner | ||
with: | ||
repository: "$PWD" | ||
# See scan.hcl at repository root for config. | ||
|
||
- name: SARIF Output | ||
shell: bash | ||
run: | | ||
cat results.sarif | jq | ||
|
||
- name: Upload SARIF file | ||
uses: github/codeql-action/upload-sarif@46a6823b81f2d7c67ddf123851eea88365bc8a67 # codeql-bundle-v2.13.5 | ||
with: | ||
sarif_file: results.sarif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,31 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: MPL-2.0 | ||
|
||
# These scan results are run as part of CRT workflows. | ||
|
||
# Un-triaged results will block release. See `security-scanner` docs for more | ||
# information on how to add `triage` config to unblock releases for specific results. | ||
# In most cases, we should not need to disable the entire scanner to unblock a release. | ||
|
||
# To run manually, install scanner and then from the repository root run | ||
# `SECURITY_SCANNER_CONFIG_FILE=.release/security-scan.hcl scan ...` | ||
# To scan a local container, add `local_daemon = true` to the `container` block below. | ||
# See `security-scanner` docs or run with `--help` for scan target syntax. | ||
|
||
container { | ||
dependencies = true | ||
alpine_secdb = true | ||
secrets = true | ||
|
||
secrets { | ||
all = true | ||
} | ||
} | ||
|
||
binary { | ||
secrets = true | ||
go_modules = true | ||
osv = true | ||
oss_index = false | ||
nvd = false | ||
} | ||
|
||
secrets { | ||
all = true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: MPL-2.0 | ||
|
||
# Configuration for security scanner. | ||
# Run on PRs and pushes to `main` and `release/**` branches. | ||
# See .github/workflows/security-scan.yml for CI config. | ||
|
||
# To run manually, install scanner and then run `scan repository .` | ||
|
||
# Scan results are triaged via the GitHub Security tab for this repo. | ||
# See `security-scanner` docs for more information on how to add `triage` config | ||
# for specific results or to exclude paths. | ||
|
||
# .release/security-scan.hcl controls scanner config for release artifacts, which | ||
# unlike the scans configured here, will block releases in CRT. | ||
|
||
repository { | ||
go_modules = true | ||
npm = true | ||
osv = true | ||
|
||
secrets { | ||
all = true | ||
} | ||
|
||
triage { | ||
suppress { | ||
paths = [ | ||
# Ignore test and local tool modules, which are not included in published | ||
# artifacts. | ||
"integration-tests/*", | ||
] | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but would align w/ the token used in core.