NET-10190 & NET-10191 - allow consul dataplane to be run as a DNS proxy without Envoy or XDS #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind address to be relaxed when running outside of sidecar mode. add validation that xds and envoy must both be either enabled or disabled.
dhiaayachi
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Thank you for working on this @jmurret, some nitpicks but nothing blocking 🚀
Co-authored-by: Dhia Ayachi <dhia@hashicorp.com>
2 tasks
jmurret
changed the title
jmurret
changed the title
jmurret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a to level
modeflag which has the follow characteristics:sidecaranddns-proxy. defaults tosidecarsidecar:-consul-dns-bind-addrand equivalent environment variable must be set to the loopback addressdns-proxyconsul-dns-bind-addrand equivalent environment variable can be set to other values besides the loopback address.