Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic docker build setup #108

Merged
merged 2 commits into from
Sep 23, 2021
Merged

basic docker build setup #108

merged 2 commits into from
Sep 23, 2021

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Apr 15, 2021

based off consul-template one, simplified
includes Makefile targets for build and push

temporary solution until new build system is in place

allows #19 to be fixed once it is merged

@eikenb eikenb requested a review from a team April 15, 2021 23:06
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🎉 The makefile changes you made are very readable! Not necessarily this PR: does this mean that the build-support directory and its contents can be deleted?

@eikenb
Copy link
Contributor Author

eikenb commented Apr 16, 2021

[..] does this mean that the build-support directory and its contents can be deleted?

Not yet, that's coming next as part of the reworking all the projects to use the new release system. It shouldn't require that build-support directory.

based off consul-template one, simplified
includes Makefile targets for build and push

temporary solution until new build system is in place
@eikenb eikenb force-pushed the docker branch 3 times, most recently from 7b76282 to 465bb96 Compare September 23, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants