Namespaces #115
Merged
Namespaces #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap out Operator.AutopilotServerHealth with Catalog.Service for determining the version of the consul servers in order to stop using the Operator based call as it requires "operator: read" ACL permissions. We don't want "operator: read" as that means ESM can read all Namespaces and we need to allow for limiting Namespace access via ACLs.
This change allows ESM to scan all accessable namespaces for services to monitor. By "accessable" we mean what Consul's ACLs/Tokens are configured to allow.
adds a new section and removes mentions of the operator permission
mkam
reviewed
Sep 23, 2021
|
|
||
| func Test_namespacesList(t *testing.T) { | ||
| testcase := "" | ||
| ts := httptest.NewServer(http.HandlerFunc( |
There was a problem hiding this comment.
This is a really cool pattern for handling the mock responses! I didn't know you could do a switch on a local variable like this in an anonymous function.
There was a problem hiding this comment.
Love that lexical scoping. :)
mkam
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Consul Enterprise Namespaces.