Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I am trying to add support for GRPC checks following #117
For some reason, when this line runs: https://github.com/VictorBac/consul-esm/blob/feature/add-grpc-checks/check.go#L488
my check is updated, but some information are deleted (causing following checks to be invalid)
Going from:
to:
and the GRPCUseTLS does not seem to be respected.
PS: to build this, I had too add GRPC to the check definition:
https://github.com/hashicorp/consul/pull/12108/files
Do you know what I am missing here ?