Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/add grpc checks #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VictorBac
Copy link

Hi guys, I am trying to add support for GRPC checks following #117

For some reason, when this line runs: https://github.com/VictorBac/consul-esm/blob/feature/add-grpc-checks/check.go#L488
my check is updated, but some information are deleted (causing following checks to be invalid)

Going from:

$ curl http://consul:8500/v1/health/node/external-node?pretty
...
            "Definition": {
                "grpc": "my-grpc-service.com:443",
                "TLSSkipVerify": true,
                "GRPCUseTLS": true,
                "interval": "10s"
            }

to:

            "Definition": {
                "TLSSkipVerify": true,
                "interval": "10s"
            }

and the GRPCUseTLS does not seem to be respected.

PS: to build this, I had too add GRPC to the check definition:
https://github.com/hashicorp/consul/pull/12108/files

Do you know what I am missing here ?

@eikenb
Copy link
Contributor

eikenb commented Jan 31, 2022

Hey @VictorBac,

I don't have time to look at this very closely but have marked it for others as much as I could. If this requires consul changes you might want to ask there about if those are absolutely needed and, if so, they'd be interested in getting it added. Once you have that done then maybe come back here and update this.

@VictorBac
Copy link
Author

Thank you @eikenb !

I am waiting for Consul to release some changes I made in their repo. Then this will work.

I'll come back when it's done.

@eikenb
Copy link
Contributor

eikenb commented Feb 14, 2022

Marked this as waiting-reply to note that we're waiting on a ping about consul having been updated so this is ready for review.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc health-checks: "check is not a valid HTTP or TCP check"
3 participants