Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -v and use standard version output #126

Merged
merged 1 commit into from
Apr 27, 2022
Merged

add -v and use standard version output #126

merged 1 commit into from
Apr 27, 2022

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Apr 26, 2022

Bring in line with other consul-eco projects behavior.

Fixes: #125

@eikenb
add -v and use standard version output
cbbb4a5 
Bring in line with other consul-eco projects behavior.
@eikenb eikenb added the bug label Apr 26, 2022
@eikenb eikenb added this to the v0.7.0 milestone Apr 26, 2022
@eikenb eikenb requested a review from a team April 26, 2022 21:29
lornasong
lornasong approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! confirmed that the version outputted aligns with the issue description. left a non-blocking question

main.go Show resolved Hide resolved
@eikenb eikenb mentioned this pull request Apr 27, 2022
Closed
@eikenb eikenb merged commit fd86a47 into main Apr 27, 2022
@eikenb eikenb deleted the version-output-update branch April 27, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornasong lornasong lornasong approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.

Add -v flag and normalize output
2 participants
@eikenb @lornasong