Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Use docker-entrypoint when running consul #1055

Closed
wants to merge 2 commits into from
Closed

Use docker-entrypoint when running consul #1055

wants to merge 2 commits into from

Commits on Aug 6, 2021

  1. Use docker-entrypoint when running consul 

    Previously we were executing consul directly via /bin/consul and we were
using the Kubernetes `command` key which overrides the default Docker
ENTRYPOINT.

This had no issues, however I propose that it's best to execute via the
entrypoint so we keep things consistent with how the Docker image was
supposed to be run. This is also consistent with Vault's Helm chart. If
you step through the entrypoint script, nothing actually changes with
how we execute consul because we don't trigger any of the `if`
statements. So there is no real effect right now.

In order to support using the entrypoint script, we need to disable part of the
script that attempts to change the ownership of the /consul directory
because the ownership is already set via Kube.

Entrypoint script is here: https://github.com/hashicorp/docker-consul/blob/master/0.X/docker-entrypoint.sh
    @lkysow
    lkysow committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    39f3fd9 View commit details
    Browse the repository at this point in the history

  2. Update custom env var test 

    Test now uses map/select instead of using fixed indices.
    @lkysow
    lkysow committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    b0cc99d View commit details
    Browse the repository at this point in the history