This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add ability to specify port for ui service #1062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
kschoche and
sadjamz
and removed request for
a team
kschoche
approved these changes
Aug 2, 2021
2 tasks
|
Closed by hashicorp/consul-k8s#604 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the same pattern as for
nodePort. This is generally useful for specifying load balancer ports and we have this option already for mesh gateways. This is also useful for running in Minikube becauseminikube tunnelwill open uplocalhost:<port>and so you can have the Consul UI onlocalhost:8500rather thanlocalhost:80.How I've tested this PR:
How I expect reviewers to test this PR: code
Checklist: