Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

add resources to injector for sidecar/init container #200

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions templates/connect-inject-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ spec:
{{- if (and .Values.connectInject.centralConfig.enabled .Values.connectInject.centralConfig.defaultProtocol) }}
-default-protocol="{{ .Values.connectInject.centralConfig.defaultProtocol }}" \
{{- end }}
{{- if .Values.connectInject.sidecarResources.enabled }}
-enable-resources=true \
-cpu-limit="{{ .Values.connectInject.sidecarResources.limits.cpu }}" \
-cpu-request="{{ .Values.connectInject.sidecarResources.requests.cpu }}" \
-memory-limit="{{ .Values.connectInject.sidecarResources.limits.memory }}" \
-memory-request="{{ .Values.connectInject.sidecarResources.requests.memory }}" \
{{- end }}
{{- if .Values.connectInject.certs.secretName }}
-tls-cert-file=/etc/connect-injector/certs/{{ .Values.connectInject.certs.certName }} \
-tls-key-file=/etc/connect-injector/certs/{{ .Values.connectInject.certs.keyName }}
Expand Down
28 changes: 28 additions & 0 deletions test/unit/connect-inject-deployment.bats
Original file line number Diff line number Diff line change
Expand Up @@ -270,3 +270,31 @@ load _helpers
yq '.spec.template.spec.containers[0].command | any(contains("-default-protocol=\"grpc\""))' | tee /dev/stderr)
[ "${actual}" = "true" ]
}

#--------------------------------------------------------------------
# sidecarResources

@test "connectInject/Deployment: sidecarResources is disabled by default" {
cd `chart_dir`
local actual=$(helm template \
-x templates/connect-inject-deployment.yaml \
--set 'connectInject.enabled=true' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].command | any(contains("-enable-resources"))' | tee /dev/stderr)
[ "${actual}" = "false" ]
}

@test "connectInject/Deployment: sidecarResources can be enabled" {
cd `chart_dir`
local actual=$(helm template \
-x templates/connect-inject-deployment.yaml \
--set 'connectInject.enabled=true' \
--set 'connectInject.sidecarResources.enabled=true' \
--set 'connectInject.sidecarResources.limits.cpu=100m' \
--set 'connectInject.sidecarResources.limits.memory=128Mi' \
--set 'connectInject.sidecarResources.requests.cpu=100m' \
--set 'connectInject.sidecarResources.limits.cpu=128Mi' \
. | tee /dev/stderr |
yq '.spec.template.spec.containers[0].command | any(contains("-enable-resources"))' | tee /dev/stderr)
[ "${actual}" = "true" ]
}
10 changes: 10 additions & 0 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -387,3 +387,13 @@ connectInject:
# configured proxy.
proxyDefaults: |
{}

# enable resources for sidecar and init containers for injector
sidecarResources:
enabled: false
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi