This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Test controller against consul:1.9.0-beta1 #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lkysow
force-pushed
the
test-1.9.0-beta1
branch
3 times, most recently
from
96a3481 to
fed5496
Compare
thisisnotashwin
force-pushed
the
test-1.9.0-beta1
branch
from
dbe3adb to
82c2e87
Compare
lkysow
requested review from
a team,
ndhanushkodi and
thisisnotashwin
and removed request for
a team
lkysow
commented
Oct 30, 2020
.circleci/config.yml
Outdated
| @@ -199,6 +199,7 @@ jobs: | |||
| -kubeconfig="$HOME/.kube/$OC_PRIMARY_NAME" \ | |||
| -secondary-kubeconfig="$HOME/.kube/$OC_SECONDARY_NAME" \ | |||
| -debug-directory="$TEST_RESULTS/debug" \ | |||
| -run TestController \ | |||
lkysow
commented
Oct 30, 2020
| // todo: remove when 1.9.0 is released. | ||
| "global.image": "hashicorpdev/consul", | ||
| "global.image": "consul:1.9.0-beta1", | ||
| "global.imageK8S": "ashwinvenkatesh/consul-k8s@sha256:2225cf62ea3c068e870ad0134dac50e4753cbcf7a1503d3d6d2d897e9fc78aa1", |
lkysow
commented
Oct 30, 2020
| "global.image": "hashicorp/consul-enterprise:1.8.4-ent", | ||
| // todo: remove when Helm chart updates to 1.9.0 | ||
| "global.image": "hashicorp/consul-enterprise:1.9.0-ent-beta1", | ||
| "global.imageK8S": "ashwinvenkatesh/consul-k8s@sha256:2225cf62ea3c068e870ad0134dac50e4753cbcf7a1503d3d6d2d897e9fc78aa1", |
thisisnotashwin
approved these changes
Oct 30, 2020
lkysow
force-pushed
the
test-1.9.0-beta1
branch
from
82c2e87 to
9d2a0a5
Compare
|
How many PRs for this one change did I open up?!? 🤯 #676 was merged so closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to hashicorp/consul-k8s#362. The only real change in this PR is to uncomment
t.Skipfor namespace tests.