This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add an acceptance test to test that connect still works when consul clients are restarted #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
force-pushed
the
enable-endpoints-controller
branch
3 times, most recently
from
b87f5c3 to
a424ea6
Compare
2 tasks
1 task
ishustava
force-pushed
the
enable-endpoints-controller
branch
3 times, most recently
from
1853230 to
304a8cb
Compare
ishustava
force-pushed
the
webhook-refactor
branch
2 times, most recently
from
1075741 to
5672e7a
Compare
ishustava
force-pushed
the
enable-endpoints-controller
branch
3 times, most recently
from
5f63a37 to
270e660
Compare
ishustava
force-pushed
the
enable-endpoints-controller
branch
from
270e660 to
fd2e0a7
Compare
ishustava
changed the title
ishustava
requested review from
a team,
kschoche and
thisisnotashwin
and removed request for
a team
ishustava
force-pushed
the
enable-endpoints-controller
branch
from
23ea74e to
8b3601f
Compare
kschoche
approved these changes
Apr 6, 2021
ndhanushkodi
approved these changes
Apr 6, 2021
thisisnotashwin
pushed a commit
that referenced
this pull request
Apr 15, 2021
* Add an acceptance test to test that connect still works when consul clients are restarted * Provide -release-name and -release-namespace flags to connect-inject deployment since they are required for endpoints controller to detect consul client pod restart events.
ishustava
added a commit
that referenced
this pull request
Apr 16, 2021
* Add an acceptance test to test that connect still works when consul clients are restarted * Provide -release-name and -release-namespace flags to connect-inject deployment since they are required for endpoints controller to detect consul client pod restart events.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: