This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Enable ent acc tests #904
Closed
Enable ent acc tests #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Leader election required creating a configmap that is owned by the instance of the controller that is the leader. This required RBAC to perform CRUD operations on configmaps to the controller. - Additionally the latest version of the controller runtime requires the controller to read "leases" from kubernetes and we now have to support that for the connect-inject controller. - Increase the number of replicas of the connect inject deployment to 3 as we can now be HA.
ishustava
force-pushed
the
enable-ent-acc-tests
branch
from
9bcf020 to
7c3e582
Compare
thisisnotashwin
changed the base branch from
feature-tproxy
to
add-leader-election
thisisnotashwin
changed the base branch from
add-leader-election
to
feature-tproxy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: